Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-864 Snapshot writing error not handled #1993

Merged
merged 3 commits into from
Oct 23, 2023
Merged

EVM-864 Snapshot writing error not handled #1993

merged 3 commits into from
Oct 23, 2023

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Oct 17, 2023 •
edited
Loading

Description

While writing itrie snapshot to the database we do not handle database errors. Also, we should handle db errors on at least very writing snapshot operation.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Oct 17, 2023
@igorcrevar igorcrevar requested a review from a team October 17, 2023 10:46
@igorcrevar igorcrevar self-assigned this Oct 17, 2023
@igorcrevar igorcrevar force-pushed the feature/snapshot_write_error branch 2 times, most recently from 953529c to 43f3c64 Compare October 17, 2023 13:13
@igorcrevar igorcrevar changed the title Snapshot write error EVM-864 Snapshot writing error not handled Oct 17, 2023
@igorcrevar igorcrevar marked this pull request as ready for review October 18, 2023 13:03
@dusan-maksimovic dusan-maksimovic requested a review from a team October 23, 2023 08:22
@igorcrevar igorcrevar merged commit 2966d12 into develop Oct 23, 2023
9 checks passed
@igorcrevar igorcrevar deleted the feature/snapshot_write_error branch October 23, 2023 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@stana-miric stana-miric stana-miric approved these changes

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorcrevar @dusan-maksimovic @stana-miric